Re: [patch 2/2] cpu hotplug notifier for updating sched domains

From: Nick Piggin
Date: Thu Sep 09 2004 - 05:49:24 EST


Rusty Russell wrote:
On Wed, 2004-09-08 at 12:19, Nick Piggin wrote:

Do you have a theoretical race here? Can we hotplug a CPU before the notifier
is registered? (I know we *can't* because it is still earlyish boot).


No, init has so many serial assumptions that this is the least of our
worries.


No. But the point is, you cannot (easily) set something up like this:

"do some setup with this specific, valid cpu_online_map";
"register notifier so we can keep everything valid";

without a race between them. Protecting the notifier chain under a
different lock is the trivial fix. I'll send the patch if you'd
like?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/