RE: [ACPI] Re: [PATCH] Oops and panic while unloading holder ofpm_idle

From: Zwane Mwaikambo
Date: Wed Sep 08 2004 - 09:29:24 EST


Hello Shaohua,

On Wed, 8 Sep 2004, Li, Shaohua wrote:

> Yes, preempt will cause oops in pc_idle. Attached patch should close the
> final race corner.

Please try and inline your patches in future, i know it may be hard with
your mail client but it makes commenting on patches easier.

while (!need_resched()) {
+ void (*idle)(void) = NULL;
+

You don't need to initialise variable `idle` here. Otherwise the rest
looks fine with me.

Thanks,
Zwane

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/