Re: [PATCH] netpoll endian fixes

From: Matt Mackall
Date: Tue Sep 07 2004 - 18:31:58 EST


On Wed, Sep 08, 2004 at 01:24:43AM +0200, Duncan Sands wrote:
> The big-endians took their revenge in netpoll.c: on i386,
> the ip header length / version nibbles need to be the other
> way round; and the htonl leaves only zeros in tot_len...

I'm completely baffled as to how length / version nibbles could be
swapped. Endianness here should be a matter of _bytes_.

The htons seems reasonable.

--
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/