Re: 2.6.9-rc1-mm4

From: Sam Ravnborg
Date: Tue Sep 07 2004 - 14:37:34 EST


On Tue, Sep 07, 2004 at 09:45:02AM -0700, Martin J. Bligh wrote:
> Well, the good news is that it compiles now, and without forcing ACPI on.
> Yay!
>
> On the downside, it seems to have a new error:
>
> make[1]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule.
>
> which appears partway through make install, but only if you do "make -j32",
> not make -j.
Fixed by following patch:

Sam

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/09/07 23:20:11+02:00 sam@xxxxxxxxxxxxxxxxx
# kbuild: fix make -j N build
#
# Make did say:
# make[1]: warning: jobserver unavailable: using -j1.
#
# Added '+' flag in relevant places to supress this warning.
# Also removed some trailing tabs in same area spotted by Adrian Bunk <bunk@xxxxxxxxx>
#
# Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
#
# Makefile
# 2004/09/07 23:19:54+02:00 sam@xxxxxxxxxxxxxxxxx +6 -5
# Add '+' to avoid '-j1' warning from make
# Removed trailing tabs
#
diff -Nru a/Makefile b/Makefile
--- a/Makefile 2004-09-07 23:28:03 +02:00
+++ b/Makefile 2004-09-07 23:28:03 +02:00
@@ -590,7 +590,7 @@
. $(srctree)/scripts/mkversion > .tmp_version; \
mv -f .tmp_version .version; \
$(MAKE) $(build)=init
-
+
# Generate System.map
quiet_cmd_sysmap = SYSMAP
cmd_sysmap = $(CONFIG_SHELL) $(srctree)/scripts/mksysmap
@@ -600,11 +600,11 @@
# Generate System.map and verify that the content is consistent

define rule_vmlinux__
- $(if $(CONFIG_KALLSYMS),,$(call cmd,vmlinux_version))
-
+ $(if $(CONFIG_KALLSYMS),,+$(call cmd,vmlinux_version))
+
$(call cmd,vmlinux__)
$(Q)echo 'cmd_$@ := $(cmd_vmlinux__)' > $(@D)/.$(@F).cmd
-
+
$(Q)$(if $($(quiet)cmd_sysmap), \
echo ' $($(quiet)cmd_sysmap) System.map' &&) \
$(cmd_sysmap) $@ System.map; \
@@ -653,9 +653,10 @@
endef

# Update vmlinux version before link
+# Use + in front of this rule to silent warning about make -j1
cmd_ksym_ld = $(cmd_vmlinux__)
define rule_ksym_ld
- $(call cmd,vmlinux_version)
+ +$(call cmd,vmlinux_version)
$(call cmd,vmlinux__)
$(Q)echo 'cmd_$@ := $(cmd_vmlinux__)' > $(@D)/.$(@F).cmd
endef
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/