Re: [PATCH 1/3] copyfile: generic_sendpage

[Gunnar Ritter]

JÃrn Engel <joern@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Tue, 7 September 2004 14:03:19 +0200, Gunnar Ritter wrote:
> > 			if (count == 0) {
> > 				done = -1;
> > 				errno = EINTR; [...]
> Is that really needed? If in_file->f_op->sendfile() returns some
> error, it's already handled above.  If it returns 0, done remains 0
> and we return 0, indicating EOF.  And the check for pending signals
> happens after handling the first chunk, so -EINTR shouldn't be
> necessary.

Yes, this was obviously not the correct location for the check then.

	Gunnar
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/