Re: [PATCH] FAT: rewrite the cache for file allocation table lookup(2/4)

[OGAWA Hirofumi]

Christoph Hellwig <hch@xxxxxxxxxxxxx> writes:

>> +#if 0
>> +#define debug_pr(fmt, args...)	printk(fmt, ##args)
>> +#else
>> +#define debug_pr(fmt, args...)
>> +#endif
>
> We have a pr_debug() in <linux/kernel.h> that you could use.

I hated KERN_DEBUG. But, well, maybe pr_debug() was enough...

I'll replace it for now, and will delete it after public test in
Andrew's tree.

>> +static inline int fat_max_cache(struct inode *inode)
>> +{
>> +	return FAT_MAX_CACHE;
>> +}
>
> Do you plan to have per-inode caches later?  This seems rather useless
> otherwise.

This cache is already per-inode.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/