Re: [PATCH] cleanup ptrace stops and remove notify_parent

[Andi Kleen]

On Tue, Aug 31, 2004 at 06:56:21PM -0700, Roland McGrath wrote:
> I don't have a program like yours to test that it was broken with my patch
> (now in 2.6.9-rc1-mm2).  But the following additional patch relative to
> 2.6.9-rc1-mm2 should do it.  I've tested that it doesn't create any new
> problems.  I don't have something right handy that tests the case in
> question, but you've said that you do.

I am travelling and can't reach the code right now, but I will
test later.

> 
> This makes any ptrace operation that finds the target in TASK_STOPPED state
> morph it into TASK_TRACED state before doing anything.  This necessitates
> reverting the last_siginfo accesses to check instead of assume last_siginfo
> is set, since it's no longer impossible to be in TASK_TRACED without being
> stopped in ptrace_stop (though there are no associated races to worry
> about).

Looks good, thanks.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/