Re: [PATCH][8/8] Arch agnostic completely out of line locks / x86_64

From: Andi Kleen
Date: Sat Sep 04 2004 - 06:38:17 EST


On Thu, Sep 02, 2004 at 08:03:02PM -0400, Zwane Mwaikambo wrote:
> arch/x86_64/kernel/time.c | 13 +++++++++++++
> arch/x86_64/kernel/vmlinux.lds.S | 1 +
> include/asm-x86_64/ptrace.h | 4 ++++
> 3 files changed, 18 insertions(+)
>
> Andi, i'm not so sure about that return address in profile_pc, i think i
> need to read a bit more.

When frame pointers are enabled the code is correct. But you don't
even need frame pointers, because the spinlock code should not
spill any registers and in such a function the return address
is always *rsp. Same is true on i386 too.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/