Re: [PATCH 2.6] watch64: generic variable monitoring system

From: Stephen Hemminger
Date: Fri Sep 03 2004 - 14:23:07 EST


On Fri, 03 Sep 2004 13:19:24 -0400
"Josef 'Jeff' Sipek" <jeffpc@xxxxxxxxxxxxx> wrote:

> The watch64 system allows the programmer to specify the approximate interval
> at which he wants his variables checked. If he tries to specify shorter
> interval than the minimum a default value of HZ/10 is used. To minimize
> locking, RCU and seqlock are used. On 64-bit systems, all is optimized away.
>
> The following patch can be also pulled from http://jeffpc.bkbits.net/watch64-2.6
>
> Josef "Jeff" Sipek.
>
> Signed-off-by: Josef "Jeff" Sipek <jeffpc@xxxxxxxxxxxxx>

- Seems like a big interface for a simple problem.
- Code doesn't match the kernel style (read Documentation/CodingStyle)
- Does it really need RCU and seqlock, wouldn't one suffice
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/