Re: [1/4] standardize bit waiting data type

[Martin Wilck]

William Lee Irwin III wrote:

> @@ -153,15 +119,13 @@
>  void __wait_on_buffer(struct buffer_head * bh)
>  {
>  	wait_queue_head_t *wqh = bh_waitq_head(bh);
> -	DEFINE_BH_WAIT(wait, bh);
> +	DEFINE_WAIT_BIT(wait, &bh->b_state, BH_Lock);
>  
> -	do {
> -		prepare_to_wait(wqh, &wait.wait, TASK_UNINTERRUPTIBLE);
> -		if (buffer_locked(bh)) {
> -			sync_buffer(bh);
> -			io_schedule();
> -		}
> -	} while (buffer_locked(bh));
> +	prepare_to_wait(wqh, &wait.wait, TASK_UNINTERRUPTIBLE);
> +	if (buffer_locked(bh)) {
> +		sync_buffer(bh);
> +		io_schedule();
> +	}
>  	finish_wait(wqh, &wait.wait);
>  }

Why don't you need a do..while loop any more ?

There is also no loop in __wait_on_bit() in the completed patch series.

Cheers
Martin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/