Re: [PATCH][1/8] Arch agnostic completely out of line locks / generic

[Linus Torvalds]

On Thu, 2 Sep 2004, Zwane Mwaikambo wrote:
> +
> +#define __lockfunc fastcall __attribute__((section(".spinlock.text")))
> +
> +int __lockfunc _spin_trylock(spinlock_t *lock)
...

> +int _spin_trylock(spinlock_t *lock);

This is horribly horribly wrong.

The function is a fastcall function, and it needs to be declared that way, 
otherwise the callers will use the wrong semantics for calling.

This can't have worked.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/