Re: [PATCH] allow i8042 register location override

[Dmitry Torokhov]

Bjorn Helgass wrote:
> Allow the default i8042 register locations to be changed at run-time.
> This is a prelude to adding discovery via the ACPI namespace.
> 
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@xxxxxx>
> 

> 
> +static unsigned long i8042_command_reg = I8042_COMMAND_REG;
> +static unsigned long i8042_status_reg = I8042_STATUS_REG;
> +static unsigned long i8042_data_reg = I8042_DATA_REG;
> +

Hi Bjorn,

This will not work as these macros are not constants, see i8042-*io.h
and i8042_platform_init(). What you need to do is add ACPI hooks to
i8042_platform_init for i386/ia64/etc.

--
Dmitry

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/