[PATCH] Fix leak in PNP interface code.

From: Dave Jones
Date: Wed Sep 01 2004 - 11:20:40 EST


Spotted with the source checker from Coverity.com.

Signed-off-by: Dave Jones <davej@xxxxxxxxxx>


diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/pnp/interface.c linux-2.6/drivers/pnp/interface.c
--- bk-linus/drivers/pnp/interface.c 2004-06-03 13:40:04.000000000 +0100
+++ linux-2.6/drivers/pnp/interface.c 2004-06-03 13:42:25.000000000 +0100
@@ -244,8 +244,10 @@ static ssize_t pnp_show_current_resource
pnp_alloc(sizeof(pnp_info_buffer_t));
if (!buffer)
return -ENOMEM;
- if (!dev)
+ if (!dev) {
+ kfree(buffer);
return -EINVAL;
+ }
buffer->len = PAGE_SIZE;
buffer->buffer = buf;
buffer->curr = buffer->buffer;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/