Re: [patch] 2.6.9-rc1-mm2: char/pcxx.c doesn't compile

[Jesper Juhl]

On Tue, 31 Aug 2004, Adrian Bunk wrote:

> On Tue, Aug 31, 2004 at 10:18:10PM +0200, Jesper Juhl wrote:
> > On Tue, 31 Aug 2004, Adrian Bunk wrote:
> > 
> > >  static void pcxxpoll(unsigned long dummy)
> > >  {
> > > @@ -1995,6 +1982,7 @@
> > >  	volatile struct board_chan *bc;
> > >  	unsigned long flags;
> > >  	int mflag = 0;
> > > +	int mstat;
> > >  
> > >  	if(ch)
> > >  		bc = ch->brdchan;
> > > @@ -2069,6 +2057,7 @@
> > >  	pcxxparam(tty,ch);
> > >  	memoff(ch);
> > >  	restore_flags(flags);
> > > +	return 0;
> > >  }
> > 
> > since pcxxpoll is declared with a void return, return 0; here seems 
> > pointless. A simple return;  or just falling off the end of the function 
> > should be fine as far as I can see.
> 
> These two chunks are _not_ in pcxxpoll.
> 
> It might look this way in the diff output, but we are already 500 lines 
> and many functions below pcxxpoll.
> 
Yeah, the diff output tricked me - looking at the actual file I see the 
above doesn't match pcxxpoll. I should have looked there before replying. 
Sorry about that.

--
Jesper Juhl <juhl-lkml@xxxxxx>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/