Re: 47 New compile/sparse warnings (over the weekend)

From: viro
Date: Mon Aug 30 2004 - 13:37:24 EST


On Mon, Aug 30, 2004 at 10:45:16AM -0700, John Cherry wrote:
> drivers/scsi/megaraid/...
<tons>

Would it be too much to ask people run make C=1 before submitting?

[snip]

> sound/usb/usx2y/usX2Yhwdep.c:218:6: warning: incorrect type in

... piece of shit code. Already fixed in a patch submitted to Linus.
And no, lack of annotations was not the worst part of it.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/