Re: [PATCH] minix fix - ? does this fix "du" bug ?!?

[Tom Oehser]

Will this patch fix the fact that 'du' is broken on minix, as a
few of us have been reporting?  (Assume yes:  Yippeedoo! Thanks!) -Tom

> In 2.5.18 some minix-specific stuff was moved to the minix
> subdirectory where it belonged. However, a typo crept in.
> A few people have complained, but so far not sufficiently loudly.
>
> The bug is of a type that automated tools might discover:
> a value res is computed, but not used.
>
> Andries
>
> Signed-off-by: Andries Brouwer
>
> diff -uprN -X /linux/dontdiff a/fs/minixdiff -uprN -X /linux/dontdiff a/fs/minix/itree_common.c b/fs/minix/itree_common.c
> --- a/fs/minix/itree_common.c	2003-12-18 03:59:05.000000000 +0100
> +++ b/fs/minix/itree_common.c	2004-08-20 23:02:26.000000000 +0200
> @@ -358,5 +358,5 @@ static inline unsigned nblocks(loff_t si
>  		res += blocks;
>  		direct = 1;
>  	}
> -	return blocks;
> +	return res;
>  }
> -
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/