Re: SMP Panic caused by [PATCH] sched: consolidate sched domains

From: James Bottomley
Date: Sun Aug 29 2004 - 12:14:30 EST


On Sun, 2004-08-29 at 13:03, William Lee Irwin III wrote:
> -#define node_to_cpumask(node) (cpu_online_map)
> +#define node_to_cpumask(node) (cpu_possible_map)

I really don't think so. This macro is also used at runtime, so there
it would return CPUs that aren't online.

It does look like all runtime uses in sched.c pass node_to_cpumask
through any_online_cpu(), so at least for the scheduler, the change may
be safe, but you'd have to audit all other runtime uses.

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/