Re: [PATCH] arm Kconfig fixes

[Dave Jones]

On Sat, Aug 28, 2004 at 02:13:44AM +0000, Linux Kernel wrote:
 > ChangeSet 1.1892, 2004/08/27 19:13:44-07:00, viro@xxxxxxxxxxxxxxxx
 > 
 > 	[PATCH] arm Kconfig fixes
 > 	
 > 	ARM dependency and makefile fixes (ACKed by rmk)
 > 	
 > diff -Nru a/drivers/char/agp/Kconfig b/drivers/char/agp/Kconfig
 > --- a/drivers/char/agp/Kconfig	2004-08-27 20:09:34 -07:00
 > +++ b/drivers/char/agp/Kconfig	2004-08-27 20:09:34 -07:00
 > @@ -1,5 +1,5 @@
 >  config AGP
 > -	tristate "/dev/agpgart (AGP Support)" if !GART_IOMMU && !M68K
 > +	tristate "/dev/agpgart (AGP Support)" if !GART_IOMMU && !M68K && !ARM
 >  	default y if GART_IOMMU
 >  	---help---
 >  	  AGP (Accelerated Graphics Port) is a bus system mainly used to

This has the opportunity to grow and grow and make things really ugly
in all the driver specific Kconfigs each time a new arch switches
over to use drivers/Kconfig.  Is this really any better than doing
this checking in drivers/Kconfig itself and keeping the subdir'd kconfig's
somewhat cleaner ?

Even if not,  I think I'd actually prefer a whitelist of drivers that *do*
support agpgart in the Kconfig, than the above which needs to be added to
all the time.  Something like if X86 && ALPHA && IA64 should cover it currently.
It just seems to me to be a lot more sensible than listing a bunch
of stuff which is completely irrelevant.

		Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/