Re: [PATCH] e1000 rx buffer allocation

From: David S. Miller
Date: Fri Aug 27 2004 - 15:11:02 EST


On Fri, 27 Aug 2004 11:36:36 -0700
Chris Leech <chris.leech@xxxxxxxxx> wrote:

> A better approach for improving jumbo frame allocations might be to
> use multiple smaller buffers for each receive, something the PRO/1000
> hardware can do but the e1000 driver has never taken advantage of.
>
> Dave, you mentioned the possibility of drivers doing that in a
> conversation with Harald about handling fragmented packets
> (http://marc.theaimsgroup.com/?l=linux-netdev&m=109293677816177&w=2)
> What would be the more correct approach to this? Putting all receive
> data into page allocations and filling out the frags array, or
> chaining together small skbs using the frag_list?

Yes, you can use multiple buffers for receive packet receive
and the network stack will handle it just fine. I would recommend
using 256 bytes for the skb->data area and put the rest in page
frags.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/