Re: silent semantic changes with reiser4

From: Linus Torvalds
Date: Thu Aug 26 2004 - 18:54:22 EST




On Thu, 26 Aug 2004 viro@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx wrote:
>
> Argh... OK, now I remember why I went for -EBUSY for unlink() (we obviously
> are not bound by SuS on that one). Consider the following scenario:
> * local file foo got something else bound on it for a while
> * we are tight on space - time to clean up
> * oh, look - contents of foo is junk
> * rm foo
> * ... oh, fuck, there goes the underlying file.

Hey, that's a valid reason for doing -EBUSY for normal bind-mounts, but it
actually _is_ what we want for an "implied-by-way-of-container-mount".
After all, when you do a "rm foo", you do mean "remove the container foo".

I replied to your earlier off-list mail in private, so let's re-iterate
for the list: the easiest way to handle this is to just have a "mount
option", and have "MNT_ALLOWUNLINK" that gets set for containers, and that
users could possibly choose to set for regular mounts too (as a mount
option) if they really want to (and if we want them to).

So there's no reason we'd have to drop existing mount behaviour only
because we also have special files that look like mountpoints.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/