Re: [PATCH] make swsusp produce nicer screen output

[Pavel Machek]

Hi!

> > Well, it looks nice, be sure to submit smooth version :-).
> I'm working on it :).

> > I'd leave dots here. Its usefull to see if it done something or not.
> 
> Well, it will display a spinning thingy that is updated every time
> shrink_all_memory(10000) returns. Maybe you want to see how much memory was
> freed?

Yes, it is quite important to see how many pages were freed even after
freeing stopped. "done (1234 pages freed)" would solve it...

> And do we need to handle the case when nr_copy_pages < 100?

It really should not crash. 100 pages is 4MB. Thats little low but
seems possible.
				Pavel
-- 
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms         

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/