Re: [PATCH] 2.6 PPC64: Another log buffer length patch.

[Paul Mackerras]

Linas,

> ===== arch/ppc64/kernel/ras.c 1.15 vs edited =====
> --- 1.15/arch/ppc64/kernel/ras.c	Mon Aug  2 03:00:41 2004
> +++ edited/arch/ppc64/kernel/ras.c	Wed Aug 25 14:46:33 2004
> @@ -108,6 +108,7 @@
>  
>  	ras_get_sensor_state_token = rtas_token("get-sensor-state");
>  	ras_check_exception_token = rtas_token("check-exception");
> +	rtas_get_error_log_max();

Why do we do this call, given that we don't use the result?  Is there
something time-critical about some future call, such that we want to
have fetched the value at this point?  If there is, it needs a comment
here, if not, let's remove this call.

Regards,
Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/