Re: Linux 2.6.9-rc1

From: David S. Miller
Date: Wed Aug 25 2004 - 18:48:28 EST


On Wed, 25 Aug 2004 22:32:06 +0200
Harald Welte <laforge@xxxxxxxxxxxxx> wrote:

Harald, a question about this fix.

> +__ip_nat_find_helper(const struct ip_conntrack_tuple *tuple)
> +{
> + return LIST_FIND(&helpers, helper_cmp, struct ip_nat_helper *, tuple);
> +}
> +
> +struct ip_nat_helper *
> ip_nat_find_helper(const struct ip_conntrack_tuple *tuple)
> {
> struct ip_nat_helper *h;
>
> READ_LOCK(&ip_nat_lock);
> - h = LIST_FIND(&helpers, helper_cmp, struct ip_nat_helper *, tuple);
> + h = __ip_nat_find_helper(tuple);
> READ_UNLOCK(&ip_nat_lock);
>

So we're converting over to using __ip_nat_find_helper().

> +EXPORT_SYMBOL(ip_nat_find_helper);

And adding an export of ip_nat_find_helper (ie. without the two underscore
prefix). Why?

If we need to export one, then we need to export both.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/