Re: [PATCH] add PCI ROMs to sysfs

[Greg KH]

On Wed, Aug 25, 2004 at 11:45:02AM -0700, Jon Smirl wrote:
> it is related to this change drivers/pci/bus.c.
> -               pci_proc_attach_device(dev);
> -               pci_create_sysfs_dev_files(dev);
> 
> The pci subsystem was initializing proc and sysfs too early from bus.c.
> Both of these calls always failed and the proc_initialized flag was
> used to return the failure. These calls were never succeeding, they
> were always getting error returns.
> 
> pci_proc_init and pci_sysfs_init run later at _initcall() time and
> build proc/sys so these routines masked the initial failure in bus.c.
> 
> If you remove the calls in bus.s there is no need for the
> proc_initialized flag.

But if you remove those calls, any pci device added later on in a pci
hotplug (or in a pcmcia) system, would not have their sysfs files, or
proc files created, right?

That doesn't seem like a good change, and is unnecessary for this rom
sysfs feature, right?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/