Re: 2.6.8.1-mm4

[William Lee Irwin III]

On Tue, Aug 24, 2004 at 02:23:45PM -0700, William Lee Irwin III wrote:
> fs/reiser4/plugin/pseudo/pseudo.c: In function `get_rwx':
> fs/reiser4/plugin/pseudo/pseudo.c:603: warning: comparison is always false due to limited range of data type

This one is a real bug.


Index: mm4-2.6.8.1/fs/reiser4/plugin/pseudo/pseudo.c
===================================================================
--- mm4-2.6.8.1.orig/fs/reiser4/plugin/pseudo/pseudo.c	2004-08-23 16:11:19.000000000 -0700
+++ mm4-2.6.8.1/fs/reiser4/plugin/pseudo/pseudo.c	2004-08-24 14:33:40.794688832 -0700
@@ -600,7 +600,7 @@
 			struct iattr newattrs;
 
 			down(&host->i_sem);
-			if (rwx == (mode_t) -1)
+			if (rwx == (umode_t)~0)
 				rwx = host->i_mode;
 			newattrs.ia_mode =
 				(rwx & S_IALLUGO) | (host->i_mode & ~S_IALLUGO);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/