Re: [PATCH 2.6] ibmveth bug fixes 4/4

[Andrew Morton]

Santiago Leon <santil@xxxxxxxxxx> wrote:
>
> his patch adds a memory barrier to ensure synchronization with the 
>  hypervisor (and avoid a panic when the hypervisor is halfway through 
>  writing to the descriptor). It also removes an unnecessary check that is 
>  flawed anyway because the value can change between the atomic_inc() and 
>  the assert. Please apply.
> 
> ...
>  @@ -733,6 +732,8 @@
>   
>   		if(ibmveth_rxq_pending_buffer(adapter)) {
>   			struct sk_buff *skb;
>  +
>  +			rmb();

Please always add a comment when adding such a barrier - it is otherwise
quite impossible for the reader to work out what it is doing in there.

Also, please in future avoid giving your patches subjects such as "ibmveth
bug fixes 4/4".  Remember that the Subject: in your email will be carried
through into kernel bitkeeper and it should be meaningful.

I relabelled these four patches as

	ibmveth: module tag fixes
	ibmveth: race fixes
	ibmveth: hypervisor return value fix
	ibmveth: add memory barrier for hypervisor synchronisation

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/