Re: [PATCH] Compile fixes for various fb drivers

[Sebastian Kügler]

On Sun, Aug 15, 2004 at 09:54, you wrote:
> On Sun, Aug 15, 2004 at 01:49:13AM +0200, Sebastian Kügler wrote:
> > fb_copy_cmap has changed in 2.6.8.1 but the change is not reflected in all
> > drivers, this updates the respective framebuffer drivers.

> NAK.
> 
> First of all, that compile fix isn't - try to compile these drivers and see
> if any got fixed by that.
> 
> While we are at it, if they would compile, you would have broken them.
> Question: what do you think the argument in question was controlling
> and why would "drop it silently" be a correct fix?

I thought that fb_copy_cmap would figure that out itself now, making the 
respective call in the driver less complicated, since the calls all looked 
the same which was a wrong assumption from my side.

> And finally, the reason why these drivers would fail to compile for quite
> a while has a lot in common with the reason why they call fb_copy_cmap()
> in the first place - they are trying to provide a method that doesn't exist
> anymore and calls in question are from the instances of that method.  Fixing
> that is going to remove these calls anyway.

Hm, *a little* more complicated than I expected in the first place. I should 
have had a look at how other drivers handle that, the mere fact that the 
driver I am using myself was not in the list should've made me alert.

Anyway, sorry for the noise and thanks for having a look at it.
-- 
sebas
- - - - - - - - - - -
http://vizZzion.org
======================
Honest disagreement is often a good sign of progress. - Mahatma Gandhi 
(1869-1948)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/