Re: [PATCH] Compile fixes for various fb drivers

[viro]

On Sun, Aug 15, 2004 at 01:49:13AM +0200, Sebastian Kügler wrote:
> Hi,
> 
> fb_copy_cmap has changed in 2.6.8.1, but the change is not reflected in all 
> drivers, this updates the respective framebuffer drivers.
> 
> The patch is against vanilla 2.6.8.1.
> 
> Signed-off-by: Sebastian Kügler <sebas@xxxxxxxxxxxx>

NAK.

First of all, that compile fix isn't - try to compile these drivers and see
if any got fixed by that.

While we are at it, if they would compile, you would have broken them.
Question: what do you think the argument in question was controlling
and why would "drop it silently" be a correct fix?

And finally, the reason why these drivers would fail to compile for quite
a while has a lot in common with the reason why they call fb_copy_cmap()
in the first place - they are trying to provide a method that doesn't exist
anymore and calls in question are from the instances of that method.  Fixing
that is going to remove these calls anyway.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/