Re: [PATCH][LIBFS] Move transaction file ops into libfs + cleanup (update)

[Francois Romieu]

James Morris <jmorris@xxxxxxxxxx> :
[...]
> diff -urN -X dontdiff linux-2.6.8.1.o/include/linux/fs.h linux-2.6.8.1.w/include/linux/fs.h
> --- linux-2.6.8.1.o/include/linux/fs.h	2004-08-14 10:25:44.000000000 -0400
> +++ linux-2.6.8.1.w/include/linux/fs.h	2004-08-14 12:57:56.175796496 -0400
> @@ -1550,6 +1550,32 @@
[...]
> +static inline void simple_transaction_set(struct file *file, size_t n)
> +{
> +	struct simple_transaction_argresp *ar = file->private_data;
> +	
> +	BUG_ON(n > SIMPLE_TRANSACTION_LIMIT);
> +	mb();
> +	ar->size = n;
> +}

Could you add the justification for the 'mb' (or the expected effect on the
api) as a comment ?

--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/