Re: [2.6.8-rc4-bk] NFS oops on x86-64

From: Trond Myklebust
Date: Fri Aug 13 2004 - 21:27:41 EST


På fr , 13/08/2004 klokka 22:21, skreiv Trond Myklebust:

> --- linux-2.6.8-rc4/fs/nfs/file.c.orig 2004-08-13 14:21:25.000000000 -0400
> +++ linux-2.6.8-rc4/fs/nfs/file.c 2004-08-13 21:50:28.000000000 -0400
> @@ -72,7 +72,7 @@ struct inode_operations nfs_file_inode_o
>
> static int nfs_check_flags(int flags)
> {
> - if (flags & (O_APPEND | O_DIRECT))
> + if (flags & (O_APPEND | O_DIRECT) == (O_APPEND | O_DIRECT))
> return -EINVAL;
Argh... I'm making mistakes too now...

Should be

if ((flags & (O_APPEND | O_DIRECT)) == (O_APPEND | O_DIRECT))

Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/