Re: [PATCH] [ix86,x86_64] cpu features.

From: Andi Kleen
Date: Fri Aug 13 2004 - 11:13:17 EST


Paweâ Sikora <pluto@xxxxxxxxxxxxx> writes:

> +++ linux-2.6.8-rc4/arch/i386/kernel/cpu/proc.c 2004-08-13 16:48:53.971370504 +0200
> @@ -44,8 +44,8 @@
> NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
>
> /* Intel-defined (#2) */
> - "pni", NULL, NULL, "monitor", "ds_cpl", NULL, NULL, "tm2",
> - "est", NULL, "cid", NULL, NULL, NULL, NULL, NULL,
> + "sse3", NULL, NULL, "monitor", "ds_cpl", NULL, NULL, "est",
> + "tm2", NULL, "cid", NULL, NULL, NULL, "xtpr", NULL,


You cannot just do the pni -> sse3 rename. That could break existing
applications that read /proc/cpuinfo and parse it. The only way would
be to add a new sse3 flag in addition to pni, but I guess that would
be not worth the ugly special case.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/