Re: [2.6 patch] let W1 select NET

[Roman Zippel]

Hi,

On Fri, 13 Aug 2004, Adrian Bunk wrote:

> > On Fri, 13 Aug 2004, Adrian Bunk wrote:
> > 
> > >  config W1
> > >  	tristate "Dallas's 1-wire support"
> > > +	select NET
> > 
> > What's wrong with a simple dependency?
> 
> it's common practice to make it easier for people configuring the kernel 
> to use select instead of depends in such cases.

select is the wrong tool for this. NET is usually enabled anyway, 
selecting it has no real advantage.
Please use normal dependency whereever possible and use select in such 
cases only as exception and with very good reason. Making kernel 
configuration easier for aunt Tillie is not such reason.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/