Re: [2.6 patch] let W1 select NET

[Adrian Bunk]

On Fri, Aug 13, 2004 at 12:54:25PM +0200, Roman Zippel wrote:
> Hi,
> 
> On Fri, 13 Aug 2004, Evgeniy Polyakov wrote:
> 
> > On Fri, 2004-08-13 at 14:32, Roman Zippel wrote:
> > > Hi,
> > > 
> > > On Fri, 13 Aug 2004, Adrian Bunk wrote:
> > > 
> > > >  config W1
> > > >  	tristate "Dallas's 1-wire support"
> > > > +	select NET
> > > 
> > > What's wrong with a simple dependency?
> > 
> > W1 requires NET, and thus depends on it.
> > If you _do_ want W1 then you _do_ need network and then NET must be
> > selected.
> 
> A simple "depends on NET" does this as well, I see no reason to abuse 
> select.

In the case of NET the discussion is mostly hypothetically since nearly 
everyone has enabled NET.

But the similar case of USB_STORAGE selecting SCSI is an example where 
select is a big user-visible improvement over depends.

> bye, Roman

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/