Re: SG_IO and security

From: Jens Axboe
Date: Thu Aug 12 2004 - 13:44:53 EST


On Thu, Aug 12 2004, Jeff Garzik wrote:
> On Thu, Aug 12, 2004 at 08:29:14PM +0200, Jens Axboe wrote:
> > close = 1;
> > ===== drivers/block/paride/pcd.c 1.38 vs edited =====
> > --- 1.38/drivers/block/paride/pcd.c 2004-07-12 10:01:05 +02:00
> > +++ edited/drivers/block/paride/pcd.c 2004-08-12 20:26:39 +02:00
> > @@ -259,7 +259,7 @@
> > unsigned cmd, unsigned long arg)
> > {
> > struct pcd_unit *cd = inode->i_bdev->bd_disk->private_data;
> > - return cdrom_ioctl(&cd->info, inode, cmd, arg);
> > + return cdrom_ioctl(&cd->info, inode, file, cmd, arg);
>
>
> If you have the struct file, can't you eliminate the inode argument?

How so?

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/