Re: [PATCH] add PCI ROMs to sysfs

From: Jon Smirl
Date: Wed Aug 11 2004 - 20:13:49 EST


I have to add a pointer to struct pci_dev to track the attribute copy
with the size in it. Would you rather have me add the pointer or or
change the sysfs rules to state that a copy of the length is made?

--- Greg KH <greg@xxxxxxxxx> wrote:
> > Greg was a little worried that your comment
> > /* .size is set individually for each device, sysfs copies it into
> dentry */
> > might not be correct.
>
> I looked at the code, and he's right. But it's pretty scary that it
> works correctly so I'd prefer to do it the way your patch did it
> (create
> a new attribute for every entry.)
>
> thnaks,
>
> greg k-h
>


=====
Jon Smirl
jonsmirl@xxxxxxxxx



__________________________________
Do you Yahoo!?
New and Improved Yahoo! Mail - Send 10MB messages!
http://promotions.yahoo.com/new_mail
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/