Re: [PATCH] Use posix headers in sumversion.c

[Sam Ravnborg]

On Tue, Aug 10, 2004 at 11:41:02PM +1000, Benno wrote:
> When compiling Linux on Mac OSX I had trouble with scripts/sumversion.c.
> It includes <netinet/in.h> to obtain to definitions of htonl and ntohl.
> 
> On Mac OSX these are found in <arpa/inet.h>. After checking the POSIX
> specification it appears that this is the correct place to get
> the definitons for these functions.
> 
> (http://www.opengroup.org/onlinepubs/009695399/functions/htonl.html)
> 
> Using this header also appears to work on Linux (at least with
> Glibc-2.3.2).
> 
> It seems clearer to me to go with the POSIX standard than implementing
> #if __APPLE__ style macros, but if such an approach is preferred I can
> supply patches for that instead.
> 
> A patch against 2.6.7 which change <netinet/in.h> -> <arpa/inet.h> is
> attached.
Your patch was reverse...
I fixed up fixdep.c as well.

Thanks,
	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/