Re: [PATCH] Make scsi.h nominally userspace-clean

From: Jens Axboe
Date: Mon Aug 09 2004 - 12:59:48 EST


On Mon, Aug 09 2004, Joerg Schilling wrote:
> >From axboe@xxxxxxx Mon Aug 9 19:52:11 2004
>
> >> scsi/scsi.h does not compile cleanly in userspace programs due to its
> >> use of ``u8''. I have confirmed this bug and prepared and tested a
> >> fix that simply changes all such uses to ``__u8''. Please consider
> >> for inclusion.
> >>
> >> I do not argue that including this header file in a program is
> >> appropriate, but other kernel headers already take as many precautions
> >> as this patch introduces. I chose __u8 over uint8_t as more in the
> >> style of the kernel generally.
> >>
> >> Please keep me on cc:; I do not subscribe to the lists.
>
> >I already sent such a patch to Linus.
>
> thank you! Did you also send a patch for sg.h to include linux/compiler.h?

Yes I did.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/