Re: [PATCH] Configure IDE probe delays

From: Todd Poynor
Date: Fri Aug 06 2004 - 15:55:03 EST


At the risk of flogging this horse after the death certificate was just signed, there were two threads running through the discussion and I wasn't sure where things stand. One thread, as I read it, was: "Don't hack around the delays, let's change the probing and do it right". The other thread was: "Don't mess around with IDE probing, leave that alone and let's do it right for SATA".

If the latter route is how things are headed then I'd still suggest replacing the scattered hardcoded "50" constants with a meaningful symbol.

If, on the other hand, IDE probe delays might someday become more complicated, such that a single symbol is not sufficient (as Alan warned against), then at least it would be easier to find 'em all. And converting some of the calls to use a new symbol for a new class of delays would be quite easy.

Anyhow, not a big deal; if there's anything I can help out with to improve the situation then I'd be glad to do so.

--
Todd Poynor
MontaVista Software

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/