Re: [6/25] Merge pmdisk and swsusp

From: Pavel Machek
Date: Fri Aug 06 2004 - 14:38:29 EST


Hi!

> Sorry about the delay; all the conferences are finally over (for
> now)

:-). Well, I'm back from canoes for now, so I'm at least able to read
the mail...

> > > +static void calc_order(void)
> > > +{
> > > + int diff;
> > > + int order;
> > > +
> > > + order = get_bitmask_order(SUSPEND_PD_PAGES(nr_copy_pages));
> > > + nr_copy_pages += 1 << order;
> > > + do {
> > > + diff = get_bitmask_order(SUSPEND_PD_PAGES(nr_copy_pages)) - order;
> > > + if (diff) {
> > > + order += diff;
> > > + nr_copy_pages += 1 << diff;
> > > + }
> > > + } while(diff);
> > > + pagedir_order = order;
> > > +}
> >
> > This code is "interesting". Perhaps at least comment would be good
> > here?
>
> Sure, patch below.

Looks good.
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/