Re: [PATCH] s390: qeth performance.

[Jörn Engel]

On Thu, 5 August 2004 15:14:40 +0200, Martin Schwidefsky wrote:
> 
> qeth network driver performance improvements. The ping time on the
> HiperSockets interface drops from 250 usecs to 50 usecs and the 1 bytes
> request/response test improves from 70000 to 110000 transactions.

Looks good.

> +config QDIO_DEBUG
> +	bool "Extended debugging information"
> +	depends on QDIO
> +	help
> +	  Say Y here to get extended debugging output in /proc/s390dbf/qdio...
> +	  Warning: this option reduces the performance of the QDIO module.
> +
> +	  If unsure, say N.
> +
>  comment "Misc"

> +#ifdef CONFIG_QDIO_DEBUG

> +#ifdef CONFIG_QDIO_DEBUG

> +#ifdef CONFIG_QDIO_DEBUG

> +#ifdef CONFIG_QDIO_DEBUG

> +#ifdef CONFIG_QDIO_DEBUG

> +#ifdef CONFIG_QDIO_DEBUG

> +#ifdef CONFIG_QDIO_DEBUG

> +#ifdef CONFIG_QDIO_DEBUG

> +#ifdef CONFIG_QDIO_DEBUG

> +#ifdef CONFIG_QDIO_DEBUG

> +#ifdef CONFIG_QDIO_DEBUG

> +#ifdef CONFIG_QDIO_DEBUG

> +#ifdef CONFIG_QDIO_DEBUG

> +#ifdef CONFIG_QDIO_DEBUG

> +#ifdef CONFIG_QDIO_DEBUG

After 50% of the patch I grew tired of it.  Martin, since when do you
like excessive use of #ifdef?

Jörn

-- 
And spam is a useful source of entropy for /dev/random too!
-- Jasmine Strong
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/