Re: MTRR driver model support broken on SMP.

From: Zwane Mwaikambo
Date: Wed Aug 04 2004 - 00:21:07 EST


On Wed, 4 Aug 2004, Nigel Cunningham wrote:

> MTRR driver support is broken on SMP because it calls smp functions with
> interrupts disabled, but interrupts should be disabled because it is
> called via device_power_up.
>
> Badness in smp_call_function at arch/i386/kernel/smp.c:565
> [<c0107f88>] dump_stack+0x1e/0x20
> [<c0116927>] smp_call_function+0x12b/0x137
> [<c011063f>] set_mtrr+0x67/0x121
> [<c0110c9b>] mtrr_restore+0x4f/0x73
> [<c0219c0f>] sysdev_resume+0x6f/0xf0
> [<c021d591>] device_power_up+0x8/0xf

Looking at this i'm really curious as to whether we need to bother at all,
can you remove the mtrr restore code and then compare /proc/mtrr before
and after suspending.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/