Re: [PATCH] idt77252.c: add missing pci_enable_device()

[Francois Romieu]

Bjorn Helgaas <bjorn.helgaas@xxxxxx> :
[...]
> ===== drivers/atm/idt77252.c 1.24 vs edited =====
> --- 1.24/drivers/atm/idt77252.c	2004-07-12 02:01:05 -06:00
> +++ edited/drivers/atm/idt77252.c	2004-07-30 13:45:42 -06:00
> @@ -3684,6 +3684,11 @@
>  	int i;
>  
>  
> +	if (pci_enable_device(pcidev)) {
> +		printk("idt77252: can't enable PCI device at %s\n", pci_name(pcidev));
> +		return -ENODEV;
> +	}
> +
>  	if (pci_read_config_word(pcidev, PCI_REVISION_ID, &revision)) {
>  		printk("idt77252-%d: can't read PCI_REVISION_ID\n", index);
>  		return -ENODEV;

It should be balanced by pci_disable_device() on close + error path.

--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/