Re: CPU hotplug broken in 2.6.8-rc2 ?

[Rusty Russell]

On Tue, 2004-08-03 at 05:38, Nathan Lynch wrote:
> diff -puN kernel/sched.c~check-for-cpu-offline-in-load_balance kernel/sched.c
> --- 2.6.8-rc2-mm2/kernel/sched.c~check-for-cpu-offline-in-load_balance	2004-08-02 13:12:04.000000000 -0500
> +++ 2.6.8-rc2-mm2-nathanl/kernel/sched.c	2004-08-02 13:12:58.000000000 -0500
> @@ -1405,6 +1405,9 @@ static int load_balance(int this_cpu, ru
>  
>  	spin_lock(&this_rq->lock);
>  
> +	if (unlikely(cpu_is_offline(this_cpu)))
> +		goto out_balanced;
> +

cpu_is_offline() is "unlikely" already.  Please just use "if
(cpu_is_offline(this_cpu))"

Thanks,
Rusty.
-- 
Anyone who quotes me in their signature is an idiot -- Rusty Russell

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/