Re: PATCH: VLAN support for 3c59x/3c90x

[Willy Tarreau]

On Fri, Jul 30, 2004 at 12:20:17PM +1000, Herbert Xu wrote:
> Willy Tarreau <willy@xxxxxxxxx> wrote:
> > 
> > I noticed a bug in the 2.4 tulip driver concerning MTU. The parameter
> > is correctly declared as a static int, initialized with default values,
> > checked by the code, but not declared as MODULE_PARM, so the user cannot
> > change it ! I wanted to send a patch but didn't find time to work on it
> > yet. So if your vlan patch fixes it, it's welcome :-)
> 
> Why is this a module parameter at all? Can't you set it using ifconfig?

no, because the driver has no change_mtu() function, so it uses the generic
one, eth_change_mtu(), which is bound to 1500.

Regards,
Willy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/