[PATCH] PPC64: ISA device tree node refcount fix

From: Paul Mackerras
Date: Thu Jul 29 2004 - 13:33:49 EST


The patch below moves a misplaced of_node_put(). In the existing code, the
node in question is used just after its refcount is decremented. Please apply.

Signed-off-by: John Rose <johnrose@xxxxxxxxxxxxxx>
Signed-off-by: Paul Mackerras <paulus@xxxxxxxxx>

diff -Nru a/arch/ppc64/kernel/pSeries_pci.c b/arch/ppc64/kernel/pSeries_pci.c
--- a/arch/ppc64/kernel/pSeries_pci.c Mon Jul 26 17:47:44 2004
+++ b/arch/ppc64/kernel/pSeries_pci.c Mon Jul 26 17:47:44 2004
@@ -284,10 +284,10 @@
isa_dn = of_find_node_by_type(NULL, "isa");
if (isa_dn) {
isa_io_base = pci_io_base;
- of_node_put(isa_dn);
pci_process_ISA_OF_ranges(isa_dn,
hose->io_base_phys,
hose->io_base_virt);
+ of_node_put(isa_dn);
/* Allow all IO */
io_page_mask = -1;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/