Re: PATCH: fix some 32bit isms

From: Andrew Morton
Date: Wed Jul 28 2004 - 11:34:11 EST


Alan Cox <alan@xxxxxxxxxx> wrote:
>
> printk(MYIOC_s_ERR_FMT
> "Invalid IOC facts reply, msgLength=%d offsetof=%d!\n",
> - ioc->name, facts->MsgLength, (offsetof(IOCFactsReply_t,
> + ioc->name, facts->MsgLength, (int)(offsetof(IOCFactsReply_t,

printk expects %zd for a size_t

> RequestFrameSize)/sizeof(u32)));
> ...
> printk(KERN_WARNING "INFTL: allocation of PUtable "
> - "failed (%d bytes)\n",
> + "failed (%ld bytes)\n",
> inftl->nb_blocks * sizeof(u16));

Some architectures will emit a warning here, and will perhaps print the
wrong thing. We need to print size_t's with %zd. I'll fix that up.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/