PATCH: fix bogus ioctl return in mtrr

From: Alan Cox
Date: Tue Jul 27 2004 - 17:59:46 EST


This is fairly self explanatory - ENOIOCTLCMD is an internal code outside of
the -1 to -511 range. The correct return for an unknown ioctl is -ENOTTY
although some Linux devices return the incorrect -EINVAL result.

Patch-By: Alan Cox <alan@xxxxxxxxxx>
OSDL Developer Certificate of Origin 1.0 included herein by reference

diff -u --new-file --recursive --exclude-from /usr/src/exclude linux-2.6.7/arch/i386/kernel/cpu/mtrr/if.c 2.6.7-ac/arch/i386/kernel/cpu/mtrr/if.c
--- linux-2.6.7/arch/i386/kernel/cpu/mtrr/if.c 2004-06-16 21:10:14.000000000 +0100
+++ 2.6.7-ac/arch/i386/kernel/cpu/mtrr/if.c 2004-06-26 19:01:54.000000000 +0100
@@ -160,7 +160,7 @@

switch (cmd) {
default:
- return -ENOIOCTLCMD;
+ return -ENOTTY;
case MTRRIOC_ADD_ENTRY:
if (!capable(CAP_SYS_ADMIN))
return -EPERM;



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/