Re: [PATCH 2.6.8-rc2] sata_nv.c

[Jeff Garzik]

Andrew Chew wrote:
> Jeff Garzik wrote:
>
>
> > Please fix and resubmit:
> > 4) [leak] driver appears to be missing a ->host_free hook, to 
> > free your 
> > nv_host_t structure.
> >
> > +       host = kmalloc(sizeof(nv_host_t), GFP_KERNEL);
>
>
> I register a host_stop routine, nv_host_stop(), that frees the host.  Is
> this not the correct way to free the nv_host?

I missed the kfree(), sorry.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/