Re: [PATCH] cpu hotplug ppc64 bug

From: Joel Schopp
Date: Tue Jul 27 2004 - 11:31:31 EST


I think that function pointers are a good idea too. But I'm not sure why that should hold up this patch. As it stands now all ppc64 platforms that do hotplug happen to be pSeries. I don't know of any other ppc64 platforms that are not pSeries who plan on doing this in the next few years. The function is already pSeries specific anyway with the rtas_stop_self call.

Meanwhile if we do not put this patch in all Power5 machines will be unable to do cpu hotplug with a mainline kernel.



I wanted to do this a bit differently - I was going to make cpu_die be
a platform-specific function called via a ppc_md function pointer,
rather than putting very pseries-specific stuff in smp.c, which is
used on all platforms. But having been on vacation and then
travelling, I haven't got to it yet.

Paul.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/