Re: [PATCH] fix readahead breakage for sequential after randomreads

From: Andrew Morton
Date: Mon Jul 26 2004 - 18:32:11 EST


Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
>
> Current readahead logic is broken when a random read pattern is
> followed by a long sequential read. The cause is that on a window
> miss ra->next_size is set to ra->average, but ra->average is only
> updated at the end of a sequence, so window size will remain 1 until
> the end of the sequential read.
>
> This patch fixes this by taking the current sequence length into
> account (code taken from towards end of page_cache_readahead()), and
> also setting ra->average to a decent value in handle_ra_miss() when
> sequential access is detected.

Thanks. Do you have any performance testing results from this patch?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/